fix/clean-up-tests

src/App/Services/AdaUsdQuoteService.php

@@ -19,14 +19,14 @@ class AdaUsdQuoteService
 
     public array $ratesArray = [];
 
-    public function __construct(protected CurrencyEnum|null $base = null, protected CurrencyEnum|null $quote = null)
+    public function __construct(public CurrencyEnum|null $base = null, public CurrencyEnum|null $quote = null)
     {
         if (!is_null($base) && !is_null($quote)) {
             $this->getHttpRate($base, $quote);
         }
     }
 
-    protected function getHttpRate()
+    public function getHttpRate()
     {
         $connector = new AdaUsdExchangeConnector();
 

src/helpers.php

@@ -16,7 +16,7 @@ if (! function_exists('ada_to_usd')) {
 }
 
 if (! function_exists('usd_to_ada')) {
-    function usd_to_ada(int|float $amount = null): float|int
+    function usd_to_ada(int|float $amount = 1): float|int
     {
         $rateInstance = new AdaUsdQuoteService(CurrencyEnum::USD, CurrencyEnum::ADA);
 

tests/AdaUsdQuoteServiceTest.php

 <?php
 
+use Lidonation\Adapayments\App\Enums\CurrencyEnum;
 use Lidonation\Adapayments\App\Services\AdaUsdQuoteService;
 
 it('can get exchange rates', function () {
     $mock = mock(AdaUsdQuoteService::class)->makePartial();
-    $mock->rateApiProviders = ['coinapi', 'coinbase'];
-    $mock->shouldReceive('coinapi')
+    $mock->base = CurrencyEnum::ADA;
+    $mock->quote = CurrencyEnum::USD;
+    $mock->ratesArray = [0.44, 0.45, 0.46];
+
+    $mock->shouldReceive('resolveCoinapi')
         ->andReturn(0.44)
         ->getMock();
+    
+    $mock->shouldReceive('resolveCoinbase')
+        ->andReturn(0.45)
+        ->getMock();
 
-    $mock->shouldReceive('coinbase')
+    $mock->shouldReceive('resolveCoinmarketcap')
         ->andReturn(0.46)
         ->getMock();